Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: optimize Conn.Next and Conn.Peek #654

Merged
merged 2 commits into from
Nov 12, 2024
Merged

opt: optimize Conn.Next and Conn.Peek #654

merged 2 commits into from
Nov 12, 2024

Conversation

panjf2000
Copy link
Owner

Besides, add tests of partial read.

Besides, add tests of partial read.
@github-actions github-actions bot added the enhancement New feature or request label Nov 11, 2024
@panjf2000 panjf2000 added the optimization Some small optimizations label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.82%. Comparing base (bdd3fb6) to head (03716c4).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
connection_windows.go 79.41% 14 Missing ⚠️
connection_unix.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #654      +/-   ##
==========================================
- Coverage   78.90%   78.82%   -0.08%     
==========================================
  Files          21       21              
  Lines        2546     2546              
==========================================
- Hits         2009     2007       -2     
- Misses        413      420       +7     
+ Partials      124      119       -5     
Flag Coverage Δ
unittests 78.82% <79.16%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 force-pushed the partial-read branch 2 times, most recently from 2e21040 to 87f41f6 Compare November 12, 2024 14:56
@panjf2000 panjf2000 merged commit a0c9787 into dev Nov 12, 2024
35 checks passed
@panjf2000 panjf2000 deleted the partial-read branch November 12, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Some small optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant